Script: wait triggers OnRepeat function and OnSustain function

joeyportnoy24

I am writing a script with different behavior for solo-click, double-click and long press.
I am scripting the solo-click behavior first, followed by the OnSustain function, followed by the OnRepeat function.
In the solo-click behavior, I would like to use "wait" during synchronize to wait for trackLeader cycle and then continue.
However, this triggers the OnRepeat function and OnSustain function for some reason (although I just pressed once and do not hold).
After that happens, additional executions of the script seem to ignore everything except the OnSustain functions, so the script becomes useless.

During testing, I found that wait does not seem to trigger OnSustain of there is no OnRepeat, but it trigger OnRepeat and both.

Is this a bug or am I doing something wrong?

alexs1

joeyportnoy24

Are you able to share the script?

This has also happened to me sometimes when binding to a MIDI command that isn’t a CC or Note with a press/release value (such as Program Change). Can you check in MIDI Monitor to see if it’s actually receiving the expected press and release values when you trigger the pad?

joeyportnoy24

I just did Binding with keyboard keys for quick testing. I hope the corresponding events (keydown and -release) are robust. Don't know how I can check those in Mobius.

Here is my simple testing code:

#name test
#sustain 100 limit 15
#repeat 400 limit 15

// ONE-CLICK BEHAVIOR #########################

wait msec 1000  //BUG: wait triggers OnRepeat and OnSustain (also triggers OnRepeat alone but not OnSustain alone)


// SUSTAIN (HOLD BEHAVIOR) #############################

function OnSustain (sustainCount) {    
	if sustainCount == 14 {
		Message("LONGPRESS")
	}
}


// MULTI-CLICK BEHAVIOR ############################

function OnRepeat (repeatCount) {
	if repeatCount == 1 {  // 2 Clicks
		Message("DoubleCLICK")
	}
}

alexs1

joeyportnoy24

Thanks for sharing. Not by my setup atm to test, but does removing the inner set of curly braces in the OnRepeat and OnSustain blocks make a difference? I think in most of my scripts they only need one pair.

joeyportnoy24

alexs1
what do you mean by the "inner set"? there is one set of braces for the function and another set for the if-clause.
the one for the if-clause can be ommitted as it is just one command following. I tested this. same behavior unfortunately...

alexs1

joeyportnoy24

Is it the same if you switch the order of OnRepeat and OnSustain (so multiclick comes first)? Also, do you have a MIDI controller to test with? Those are only some more guesses, but it might just be a bug.

joeyportnoy24

Switching the order of OnRepeat and OnSustain makes no difference in behavior.
A also tested with a MIDI controller: same behavior except that after the first MIDI command, only OnRepeat seems to be triggered (LONGPRESS message does not appear). From the second command on, the behavior is the same: only OnSustain is triggered.

Interestingly, if I add a message for the first click before the wait, this also never appears. It seems as if the script directly jumps to OnRepeat and OnSustain after a short time (this time also seems to be independent of the waiting time stated in the wait statement and also from the statements about the OnRepeat timing...
This must be a bug.

jeff

Need to run some tests, but after a quick glance, there is no situation where a wait in the main body of the script should cause either the OnRepeat or OnSustain functions to run. So if that is happening it's a bug.

Whenever OnRepeat or OnSustain behave strangely, the first thing I do is bring up the Midi Monitor window and watch the events being sent by the controller. Make sure that pairs of NoteOn and NoteOff messages are being sent (or CC 127, CC 0 if you're using CCs). Also check for duplications or the same message being received through different paths, such as both the host and a direct MIDI device.